test creation of collections when valkyrie resource & fix failures #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
val_col_create_tests
branch
from
d478da9 to
6185e98
Compare
elrayle
force-pushed
the
val_col_create_tests
branch
4 times, most recently
from
3b3659f to
3f07cf1
Compare
elrayle
changed the title
…mCollection’ NOTE: A few tests pass without requiring changes. Those were not marked pending.
elrayle
force-pushed
the
val_col_create_tests
branch
from
3f07cf1 to
ebe5f72
Compare
elrayle
commented
Dec 9, 2021
| @@ -220,6 +220,7 @@ def valkyrie_create | |||
| @collection = transactions['change_set.create_collection'] | |||
| .with_step_args( | |||
| 'change_set.set_user_as_depositor' => { user: current_user }, | |||
| 'change_set.add_to_collections' => { collection_ids: Array(params[:parent_id]) }, | |||
There was a problem hiding this comment.
Fixes failure to set parent collection in test: #create when params includes parent_id
elrayle
commented
Dec 9, 2021
| @@ -390,7 +395,8 @@ def collection_params | |||
| form_class.model_attributes(params[:collection]) | |||
| else | |||
| params.permit(collection: {})[:collection] | |||
| .merge(params.permit(:collection_type_gid)) | |||
| .merge(params.permit(:collection_type_gid) | |||
| .with_defaults(collection_type_gid: default_collection_type_gid)) | |||
There was a problem hiding this comment.
fixes failure to set collection type in test: #create when setting collection type and collection type is not passed
dlpierce
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for creating collections when the collection is processed as a Hyrax::PcdmCollection which is a Valkyrie::Resource. Marks pending tests for other actions (e.g. update, edit, show), except for a few that pass as written.
Fixes several failing tests:
@samvera/hyrax-code-reviewers