Refactor process for resetting collection ACLs to PermissionTemplate settings #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 16, 2021 14:32
both collections and admin sets have (ActiveFedora) implementations of `#reset_access_controls!`. the behavior differs very slightly, but a good portion of the underlying private method footprint is a case character-for-character code duplication. extract the dupliated behavior to the common collaborator `PermissionTemplate`.
extract and provide one implementation of `AdminSet/Collection#reset_access_controls!` these methods had a lot in common. extracting them to a single implementation makes space for deprecating the ActiveFedora::Base versions of them, and provides a home for a valkyrie compatible implementation.
this behavior is now extracted to the PermissionTemplate. use that implementation internally, and recommend others do the same.
no-reply
changed the title
no-reply
commented
Jul 16, 2021
|
I like inverting from (in summary) |
jeremyf
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract and provide one implementation of
AdminSet/Collection#reset_access_controls!these methods had a lot in common. extracting them to a single implementation sets us up to add a valkyrie ready version of this behavior.
@samvera/hyrax-code-reviewers