handle optional :sort option for attribute renderers
#5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cjcolvar
reviewed
Jun 30, 2021
Comment on lines
34
to
39
| values_array = Array(values) | ||
| values_array.sort! if options[:sort] | ||
|
|
||
| markup += values_array.map do |value| |
There was a problem hiding this comment.
Do we need to worry at all about modifying the order of the passed in values? Would sort be safer?
There was a problem hiding this comment.
probably. good call. 👍🏻
cjcolvar
reviewed
Jun 30, 2021
yeah, you're right. i'll take a second pass through to do some quick docs and a test in the AM. |
|
removed array mutation and added a yard annotation for the new option |
following a suggestion in #395, introduce a `:sort` option for renderers and a startlingly naive implementation.
jeremyf
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following a suggestion in #395, introduce a
:sortoption for renderers and a startlingly naive implementation.@samvera/hyrax-code-reviewers