don't show the "Add to collection" action when type isn't nestable #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
commented
May 28, 2021
| <%= link_to "#", | ||
| class: 'itemicon add-to-collection', | ||
| title: t("hyrax.dashboard.my.action.add_to_collection"), | ||
| data: { nestable: false, |
There was a problem hiding this comment.
this line guaranteed that the deny modal will be used here.
the previous guard skipped showing this button only if no collection types were nestable (checking this involved a solr query). it would then base the actual behavior on the current collection type's nestability. in the case of admin sets, it was even hard coded to false! instead, check whether the current type is nestable. this avoids the most common case where the user might push this button only to be given a deny popup. since none of the data is loaded in dynamically in response to the button push, there's no reason we can't remove that modal implementation altogether.
dlpierce
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous guard skipped showing this button only if no collection types were
nestable (checking this involved a solr query). it would then base the actual
behavior on the current collection type's nestability. in the case of admin
sets, it was even hard coded to false!
instead, check whether the current type is nestable. this avoids the most common
case where the user might push this button only to be given a deny popup. since
none of the data is loaded in dynamically in response to the button push,
there's no reason we can't remove that modal implementation altogether.
@samvera/hyrax-code-reviewers