don't reload the collection to populate subcollection modal #4986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this view used to call
#find
to retirieve a collection from an id. we alreadyhave a presenter and a solr document, so there's no need for this.
instead, allow
Hyrax::Ability
to resolveCollectionPresenter
to itsunderlying
SolrDocument
. AddCollectionPresenter#nestable?
as an alias tothe existing
#collection_type_is_nestable?
to match theCollection
interface, and pass the presenter through to the modal. we continue to pass the
id into the modal for backward compatibility.
Guidance for testing:
@samvera/hyrax-code-reviewers