-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging overhaul #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resources directory is intended for things that are embedded into, or otherwise needed by, the main phrog binary. The data directory is for stuff that should be dropped in the filesystem somewhere to support phrog at runtime. Put differently, resources/ is for the build, data/ is for the packaging scripts. Signed-off-by: Sam Day <me@samcday.com>
This comment has been minimized.
This comment has been minimized.
ce8c8b5
to
d282634
Compare
This comment has been minimized.
This comment has been minimized.
d282634
to
19146fc
Compare
/packit build |
This comment has been minimized.
This comment has been minimized.
19146fc
to
a9d3e4d
Compare
This comment has been minimized.
This comment has been minimized.
/packit build |
a9d3e4d
to
467d4d2
Compare
This comment has been minimized.
This comment has been minimized.
/packit build |
467d4d2
to
5deb159
Compare
This comment has been minimized.
This comment has been minimized.
/packit build |
Booting a fully-functional phrog greeter session under greetd is a little complicated. The right way to do it varies by distribution. This commit introduces prescriptive configuration for Alpine and Fedora. Eventually Debian will be a first-class citizen here too (when I finally wrap my head around its packaging/tooling). Since Alpine already allows the greetd config file to be specified in /etc/conf.d/greetd, we make use of that. On Fedora, a distinct phrog.service unit is introduced which conflicts with greetd's default greetd.service. For now, the only difference this service has to the default is a --config arg. Later, when we support Plymouth flicker-free boot, it will also Conflict=plymouth-quit.service to take over that process (just like gdm.service does). This commit also introduces the use of gnome-session to run the phrog shell. This ensures auxiliary services like the gsd-* daemons and an OSK are present. Since gnome-session is in place, we also use that to spawn phrog itself. A mobi.phosh.Phrog.desktop file is now shipped for that. The phrog-session wrapper example Guido introduced recently is moved to data/ and shipped in Alpine and Fedora. Since this script is only intended to be referenced by greetd's default_session.command config, it goes in /usr/libexec rather than in the PATH. As such the --help and --version are excised, and the script is made as minimal as possible. The README is updated and cleaned up a bit to reflect this work. Signed-off-by: Sam Day <me@samcday.com>
5deb159
to
7a3199d
Compare
I've tested the reworked packages across a collection of Fedora/Alpine devices, confirming OSK presence and proper power management. Going to land this now and cut a 0.44 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #70