Fix trivial_flow test + other cleanups/improvements #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Day <me@samcday.com>
Panics from spawn_future_local are caught by glib/glib-rs, so we need to propagate the JoinHandle result properly. Signed-off-by: Sam Day <me@samcday.com>
It was being emitted for the *destination path*, rather than the source. Since it only looks at mtime, this meant the crate was being rebuilt constantly. The code was also simplified to use std::fs::copy. Signed-off-by: Sam Day <me@samcday.com>
Since the Shell is a singleton, and the session list is static information obtained once on startup, it fits better. This also makes it easier to mock the sessions data during tests. Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
Signed-off-by: Sam Day <me@samcday.com>
samcday
force-pushed
the
session-list-mock
branch
from
00e5706 to
e02e84b
Compare
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
keypad-shuffle
simple-flow
trivial-flow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89