Yeet static builds + vendoring #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcday
force-pushed
the
yeet-static-plus-vendoring
branch
2 times, most recently
from
943db5b to
2ce7d68
Compare
|
Also yeeting Packit builds until #23 is completed, as those RPM builds were relying on the vendored |
samcday
force-pushed
the
yeet-static-plus-vendoring
branch
3 times, most recently
from
d0519fa to
257ba25
Compare
In the early development of phrog, this was much more useful. Now, it's a liability. The subtree merges are inexplicably brutal, even though the vendorered trees here don't diverge *that* much. It's just not worth the effort, especially since the upstream codebases are much more active than this project is or ever will be. Ultimately, there was never going to be any significant number of folks running a build of phrog with phosh statically linked, besides local development. The latter case will be more friction-y for sure, but oh well.
samcday
force-pushed
the
yeet-static-plus-vendoring
branch
from
257ba25 to
8840a43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.