Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto_include: false isn't honored with HABTM #34

Closed
gavri opened this issue Aug 4, 2016 · 2 comments
Closed

auto_include: false isn't honored with HABTM #34

gavri opened this issue Aug 4, 2016 · 2 comments
Assignees
@jturkel

Comments

@gavri
Copy link

gavri commented Aug 4, 2016

gavri@faad975
@jturkel
Copy link
Member

jturkel commented Aug 5, 2016

Looks like as of Rails 4.1 has_and_belongs_to_many creates a has_many association under the covers and the auto_include option isn't propagated to this association. Rails 3.2 and 4.0 are unaffected. I'm working on a fix.

@jturkel jturkel self-assigned this Aug 5, 2016
jturkel added a commit that referenced this issue Aug 5, 2016
@jturkel
HABTM associations now honor the auto_include option. Fixes #34
1e472e6
@jturkel jturkel mentioned this issue Aug 5, 2016
Closed
@gavri
Copy link
Author

gavri commented Aug 5, 2016

Thanks!

@jturkel jturkel closed this as completed in 9b7b0e4 Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jturkel jturkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HABTM associations now honor the auto_include option salsify/goldiloader
2 participants
@gavri @jturkel