Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a Pull Request template / checklist #94

Merged
merged 3 commits into from
May 4, 2022
Merged

chore: Add a Pull Request template / checklist #94

merged 3 commits into from
May 4, 2022

Conversation

bgrant
Copy link
Collaborator

@bgrant bgrant commented May 4, 2022 •
edited
Loading

Add a PR template to remind us of things that need doing. Particularly, we
often forget to update the CHANGELOG.

  • Update CHANGELOG.md
  • Update README.md (as needed)
  • New dependencies were added to requirements.txt or requirements-dev.txt
  • pip install succeeds with a clean virtualenv
  • There are new or modified tests that cover changes
  • Test coverage is maintained or expanded

@bgrant bgrant requested review from smholloway and snacu May 4, 2022 18:36
snacu
snacu previously approved these changes May 4, 2022
View reviewed changes
@bgrant bgrant requested a review from snacu May 4, 2022 18:54
@bgrant bgrant merged commit 7c5ab62 into main May 4, 2022
@bgrant bgrant deleted the chore/add-pull-request-template branch May 4, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snacu snacu snacu approved these changes

@smholloway smholloway Awaiting requested review from smholloway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgrant @snacu