Allow Celery 5 by using shared_task
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #80 |
demianbrecht
reviewed
Jan 6, 2022
| @@ -1,5 +1,5 @@ | |||
| Django~=2.2.0 | |||
| celery>=4.0.2,<=4.4.0,!=4.1.0 | |||
There was a problem hiding this comment.
Do you know why 4.1.0 was excluded? I'd imagine that we ran into an issue with it at some point.
There was a problem hiding this comment.
Added the exclusion back 👍
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| import logging | |||
| from pydoc import locate | |||
| from celery.task import task as celery_task | |||
There was a problem hiding this comment.
Looks shared_task has been around for ages. Curious as to why it wasn't originally used.
demianbrecht
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
celery.task.taskwithcelery.shared_taskseems to fix the testson Celery 5 (they continue to work with Celery 4 as well).
I don't know enough about Celery to be sure this is the right fix, but
I'm going off of this:
https://docs.celeryproject.org/en/stable/userguide/tasks.html
First steps with Django — Celery 5.2.3 documentation