Feature/allow renaming expandable foreign keys #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshafer
force-pushed
the
feature/allow-renaming-expandable-foreign-keys
branch
from
4c3942e to
652fc76
Compare
demianbrecht
previously approved these changes
Jun 8, 2020
| inst_field_name = field_type.inst_field_name or field_name | ||
| val = getattr(inst, inst_field_name) | ||
| else: | ||
| val = _get_unexpanded_field_value(inst, field_name, field_type) |
There was a problem hiding this comment.
This doesn't need the same inst_field_name treatment because it's not actually hitting the model, right?
There was a problem hiding this comment.
it does need it, and accesses it within the called function as field_type.inst_field_name (line 46)
dshafer
force-pushed
the
feature/allow-renaming-expandable-foreign-keys
branch
from
652fc76 to
2eec430
Compare
demianbrecht
approved these changes
Jun 9, 2020
|
Thanks for the contribution! It looks like @dshafer is an internal user so signing the CLA is not required. However, we need to confirm this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue where I wanted the name of an expandable field to be different than the name of the field on the underlying model
Fixes #41