Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade django 4.2 LTS (@W-14178534) #148

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

rohansroy
Copy link
Collaborator

@rohansroy rohansroy commented Jan 31, 2024

  • Update CHANGELOG.md
  • Update README.md (as needed)
  • New dependencies were added to pyproject.toml
  • pip install succeeds with a clean virtualenv
  • There are new or modified tests that cover changes
  • Test coverage is maintained or expanded

@rohansroy rohansroy requested a review from bgrant January 31, 2024 13:18
@bgrant
Copy link
Collaborator

bgrant commented Jan 31, 2024

Would you mind adding to the CHANGELOG.md?

@bgrant
Copy link
Collaborator

bgrant commented Jan 31, 2024

Testing with our service often uncovers problems with DDA changes that the unit tests don't. I'll leave it to you if you want to go ahead and merge this change or wait until you do that testing.

Copy link
Collaborator

@bgrant bgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a line to the CHANGELOG.md?

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [PR 144](/~https://github.com/salesforce/django-declarative-apis/pull/141) Allow Dependabot to update dev dependencies
- [PR 143](/~https://github.com/salesforce/django-declarative-apis/pull/143) Testing: Replace `flake8` and `black` with `ruff`, add testing for Python 3.12, drop testing for Python 3.7
- [PR 146](/~https://github.com/salesforce/django-declarative-apis/pull/146) Add ExpandableGeneric filter type
- [PR 148](/~https://github.com/salesforce/django-declarative-apis/pull/148) chore: upgrade django 4.2 LTS (@W-14178534)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this.

It looks like we forgot to update this CHANGELOG the last time we released DDA. This release contains the "ExpandableGeneric" filter type (and I assume the PRs before it):

Release Django Declarative APIs v0.31.6 · salesforce/django-declarative-apis

This isn't your mistake, but would you mind fixing the CHANGELOG?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could potentially fix it in the PR when you make a release, so I'll go ahead and approve this PR.

@bgrant bgrant self-requested a review February 7, 2024 15:07
Copy link
Collaborator

@bgrant bgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue with the CHANGELOG. Would you mind fixing it when you update the CHANGELOG as part of making a new release?

@rohansroy
Copy link
Collaborator Author

I found an issue with the CHANGELOG. Would you mind fixing it when you update the CHANGELOG as part of making a new release?

will do, to save time i'll merge this and fix the changelog with the release PR.

@rohansroy rohansroy merged commit f807ba1 into main Feb 7, 2024
10 checks passed
@rohansroy rohansroy deleted the chore/upgrade-django-4.2-lts branch February 7, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants