Handle celery errors by re-running async task #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smholloway
reviewed
Jan 30, 2020
| return | ||
| except kombu.exceptions.OperationalError as err: | ||
| logger.warn('kombu.exceptions.OperationalError') | ||
| pass |
There was a problem hiding this comment.
Should we log how many attempts we're at and if we hit 3?
dshafer
reviewed
Jan 31, 2020
| except kombu.exceptions.OperationalError as err: | ||
| logger.warn('kombu.exceptions.OperationalError (attempt: %s)', attempt) | ||
| if attempt >= MAX_ATTEMPTS - 1: | ||
| raise err |
There was a problem hiding this comment.
I'd like to have the option to fall back to running the task synchronously, perhaps controlled by a django setting, or else an option in the DeferrableTask decorator
|
I like |
|
@dshafer so demanding ;) Should be satisfied by the most recent commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.