Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Correct documentation for default value of required on field #139

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Docs: Correct documentation for default value of required on field #139

merged 2 commits into from
Oct 23, 2023

Conversation

bgrant
Copy link
Collaborator

@bgrant bgrant commented Oct 23, 2023 •
edited
Loading

  • Update CHANGELOG.md
  • Update README.md (as needed)
  • New dependencies were added to pyproject.toml
  • pip install succeeds with a clean virtualenv
  • There are new or modified tests that cover changes
  • Test coverage is maintained or expanded

@bgrant bgrant requested review from dshafer and smholloway October 23, 2023 18:44
smholloway
smholloway approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@smholloway smholloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've changed true to false. I defer to Drew on what was expected

@bgrant bgrant merged commit fc09da3 into main Oct 23, 2023
5 checks passed
@bgrant bgrant deleted the chore/correct-field-docs branch October 23, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshafer dshafer dshafer approved these changes

@smholloway smholloway smholloway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgrant @smholloway @dshafer