Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contributing doc #103

Merged
merged 1 commit into from
Nov 3, 2022
Merged

update contributing doc #103

merged 1 commit into from
Nov 3, 2022

Conversation

demianbrecht
Copy link
Member

@demianbrecht demianbrecht commented Nov 3, 2022 •
edited
Loading

contributing.md has a couple old links and names. This updates them.

  • Update CHANGELOG.md
  • Update README.md (as needed)
  • New dependencies were added to requirements.txt or requirements-dev.txt
  • pip install succeeds with a clean virtualenv
  • There are new or modified tests that cover changes
  • Test coverage is maintained or expanded

@demianbrecht demianbrecht requested a review from bgrant November 3, 2022 17:07
@demianbrecht demianbrecht changed the title updated contributing doc update contributing doc Nov 3, 2022
bgrant
bgrant approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@bgrant bgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@demianbrecht demianbrecht merged commit 00a7854 into main Nov 3, 2022
@demianbrecht demianbrecht deleted the update-contributing branch November 3, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant bgrant bgrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demianbrecht @bgrant