compat check: fix logic for Web Patch (re)install #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b100dian
approved these changes
Feb 25, 2023
src/qml/WebPatchPage.qml
Outdated
|
|
||
| onClicked: { | ||
| if ((PatchManager.sfosVersionCheck !== VersionCheck.Strict) && !isCompatible) { | ||
| if (fileDelegate.isReinstallable) { |
There was a problem hiding this comment.
consistency nit: is fileDelegate. needed
- here specifically
- in all accesses for the properties changed in this PR (
isCompatible,forceCompatible) or - in none of the cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fallout from #408
The logic prevents installation of incompatible patches from Web Catalog despite (or in the reverse meaning of) the VersionCheck setting.
At first I attributed this to the migrated settings bug #405, but it's a separate issue.
Please review the logic, could be I missed a case.