Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend README a bit #393

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Extend README a bit #393

merged 4 commits into from
Jan 24, 2023

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Jan 23, 2023

No description provided.

@Olf0 Olf0 added enhancement this improves something documentation documentation, Wiki and related labels Jan 23, 2023
@Olf0 Olf0 self-assigned this Jan 23, 2023
@Olf0
Copy link
Contributor Author

Olf0 commented Jan 23, 2023 •
edited
Loading

@nephros, if tests/README_patching.md is simply called tests/README.md it should be automatically displayed when viewing /~https://github.com/sailfishos-patches/patchmanager/blob/master/tests

You might consider to change that (or tell me, if you want that). The the link in the top README would have to be adapted, then. Hence it might make sense to add this change to this PR, if you want that.

Olf0
Olf0 commented Jan 23, 2023
View reviewed changes
Copy link
Contributor Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be O.K. now.

@Olf0
Copy link
Contributor Author

Olf0 commented Jan 23, 2023 •
edited
Loading

@nephros, if tests/README_patching.md is simply called tests/README.md it should be automatically displayed when viewing /~https://github.com/sailfishos-patches/patchmanager/blob/master/tests

You might consider to change that (or tell me, if you want that). The the link in the top README would have to be adapted, then. Hence it might make sense to add this change to this PR, if you want that.

I interpret no reply, while you have approved this PR, as a "no, at least not in this PR", correct?

@nephros
Copy link
Contributor

nephros commented Jan 24, 2023

@nephros, if tests/README_patching.md is simply called tests/README.md it should be automatically displayed when viewing /~https://github.com/sailfishos-patches/patchmanager/blob/master/tests
You might consider to change that (or tell me, if you want that). The the link in the top README would have to be adapted, then. Hence it might make sense to add this change to this PR, if you want that.

I interpret no reply, while you have approved this PR, as a "no, at least not in this PR", correct?

Thanks for the hint, done! :)

Olf0
Olf0 commented Jan 24, 2023
View reviewed changes
Copy link
Contributor Author

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Olf0 Olf0 merged commit 8df853d into master Jan 24, 2023
@Olf0 Olf0 deleted the extend-README branch January 24, 2023 16:54
@Olf0
Copy link
Contributor Author

Olf0 commented Jan 24, 2023

Thanks for the hint, done! :)

Works fine, is looking good IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nephros nephros nephros approved these changes

Assignees

@Olf0 Olf0

Labels
documentation documentation, Wiki and related enhancement this improves something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Olf0 @nephros