-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't force ecl lisp with maxima -l ecl
on command line.
#35514
Conversation
Instead, use `maxima` which should run maxima under the default lisp. This is consistet with what happens with `sage.interfaces.maxima`. Note that `maxima_lib` needs maxima built with ecl, but the pexpect interface to maxima works with any lisp and there are faster builds of maxima (e.g. the one compiled with sbcl).
I'll admit, that was my doing some time ago. |
Is this the only place? I thought I had put it somewhere else. |
I think this is the only place left. Please check that it still works ok for you after this change. |
It will work. The only thing is that if you have maxima compiled with more than one lisp, the ecl backend is unlikely to get chosen as most of the others are before it in the picking order. Occasionally, you may get a different result. But this is only concerning the pexpect interface to maxima. maximalib will still use ecl. I will check env.py and sage_conf which are two places where I could have put stuff. |
I thought I had put stuff there as well /~https://github.com/sagemath/sage/blob/develop/pkgs/sage-conf/_sage_conf/_conf.py.in#L12 but if I have, it has been removed. Removing Waiting for the last checks to run before giving you my tick. |
Documentation preview for this PR is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's freely use any maxima.
Instead, use
maxima
which should run maxima under the default lisp. This is consistet with what happens withsage.interfaces.maxima
.Note that
maxima_lib
needs maxima built with ecl, but the pexpect interface to maxima works with any lisp and there are faster builds of maxima (e.g. the one compiled with sbcl).