Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer guide for workflows on github #35460

Merged
merged 37 commits into from
May 20, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Apr 8, 2023

📚 Description

Our developer guide needs to be updated incorporating the new workflows on GitHub. Here is the updated developer guide.

I know this needs more editing, but at least it reached the point where other eyes would catch more errors, typos, and defects than mine alone.

So please examine the built documentation and report errors, typos, and defects. If you think a major addition such as a new section is needed, then please open a new PR that builds on this PR and provide your own writing.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title Update developer guide for workflows on github: "advanced git" section Update developer guide for workflows on github Apr 8, 2023
Sage Trac server <https://trac.sagemath.org>`_) will become obsolete and be
updated according to the new workflow on GitHub. See our `transition guide from Trac to
GitHub
</~https://github.com/sagemath/trac-to-github/blob/master/docs/Migration-Trac-to-Github.md>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should remove the link to the transition guide just yet. Developers familiar with the Trac workflow but new to GitHub still could benefit from it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR would take long to be complete. The next sage release would go with the old developer manual. Perhaps we need another PR to update the banner for the release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #35482 for this purpose.

vbraun pushed a commit that referenced this pull request Apr 13, 2023
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

Updating the developer manual with the new workflow on github would take
some time. #35460 Meanwhile, we update the github transition notices in
the developer manual as the transition is over now.

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35482
Reported by: Kwankyu Lee
Reviewer(s): Matthias Köppe
@kwankyu kwankyu force-pushed the developer-update branch from 2f42d10 to 34514e8 Compare May 6, 2023 16:29
@kwankyu kwankyu force-pushed the developer-update branch from 34514e8 to 4bd4d85 Compare May 6, 2023 16:49
@kwankyu kwankyu marked this pull request as ready for review May 8, 2023 09:11
@mkoeppe
Copy link
Contributor

mkoeppe commented May 8, 2023

sage -t --random-seed=234014508624697890155821715594653346005 doc/en/developer/github.rst  # Tab character found
sage -t --random-seed=234014508624697890155821715594653346005 doc/en/developer/workflows.rst  # Tab character found

@kwankyu kwankyu force-pushed the developer-update branch from 0dfa7f7 to f5af640 Compare May 9, 2023 12:39
@kwankyu
Copy link
Collaborator Author

kwankyu commented May 10, 2023

What I'm missing a bit (but which is of course also not the subject of this PR), is a very short overview for someone that knows git and github, but not sage.

Yes, that may be a good addition. I expect a sequel PR for that from you.

If you know these things its hard to pick out the few important sentences that are currently hidden in the mountain of git explanations (which are of course very important for eg students). This hopefully also helps with on-boarding new devs.

That may a section of the index page that guides what to read and what to skip.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 11, 2023

Thanks!

Sorry for the late commits, where I removed some links to non-existing references and made some minor edits.

@vbraun
Copy link
Member

vbraun commented May 15, 2023

sage -t --long --warn-long 45.0 --random-seed=123 src/doc/en/developer/workflows.rst  # Tab character found
sage -t --long --warn-long 45.0 --random-seed=123 src/doc/en/developer/github.rst  # Tab character found

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 15, 2023

Thanks. Fixed.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 4719a3f

@vbraun vbraun merged commit 8476c46 into sagemath:develop May 20, 2023
@kwankyu kwankyu deleted the developer-update branch December 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants