Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed redundant imports from matrix_modn_dense_float.pyx #35426

Merged
merged 2 commits into from
Apr 13, 2023
Merged

removed redundant imports from matrix_modn_dense_float.pyx #35426

merged 2 commits into from
Apr 13, 2023

Conversation

aadya940
Copy link
Contributor

@aadya940 aadya940 commented Apr 3, 2023

"Fixes #35364 "

@vneiger vneiger assigned vneiger and unassigned vneiger Apr 6, 2023
@vneiger vneiger self-requested a review April 6, 2023 06:18
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 750cabb

@vneiger
Copy link
Contributor

vneiger commented Apr 10, 2023

Thanks for the fix, looks good to me.

@@ -31,7 +31,7 @@ from sage.libs.linbox.linbox cimport \

from sage.libs.linbox.fflas cimport \
fgemm, pfgemm, fgemv, Det, pDet, Rank, pRank, ReducedRowEchelonForm, pReducedRowEchelonForm, applyP, \
MinPoly, CharPoly, MinPoly, \
MinPoly, CharPoly, \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, lgtm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;-)

@vbraun vbraun merged commit 6371a81 into sagemath:develop Apr 13, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinPoly imported twice in matrix_modn_dense_float.pyx
4 participants