-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a save method to class Standalone/TikzPicture for compatibility with sagetex #35394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
one failing doctest, see the checks |
the log of the build of the pdf finishes with:
Is the PR responsible of that? |
It seems that the pdf doc build is also broken on many other recent pull requests. |
ok |
so what happens in this situation? |
fchapoton
reviewed
Apr 4, 2023
fchapoton
reviewed
Apr 4, 2023
fchapoton
reviewed
Apr 4, 2023
fchapoton
reviewed
Apr 4, 2023
fchapoton
reviewed
Apr 4, 2023
fchapoton
reviewed
Apr 4, 2023
seblabbe
force-pushed
the
tikz_save_method
branch
from
April 4, 2023 15:25
4d107d8
to
fed096b
Compare
fchapoton
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, c'est correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a save method to class Standalone/TikzPicture for compatibility with sagetex. In particular, so that
\sageplot{t}
works whent
is an instance of Standalone/TikzPicture classes.For example the following
file.tex
:will compile fine with the commands:
provided the
sagetex.sty
file is in the same repository.Since sagetex creates by defaults
eps
andpdf
images, we added methodsdvi
andeps
to the class Standalone following what was done in the other methods. Also, we added a featuredvips
to tag the doctests with this new external feature. Finally, we made a small improvement to the latex feature by providing more information in the reason why a latex feature does not work.