Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix E502 in schemes and combinat #35318

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

fix pycodestyle E502 warning in schemes/ and combinat/

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Patch coverage: 78.86% and project coverage change: -0.01 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (5fa42e9) 88.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35318      +/-   ##
===========================================
- Coverage    88.62%   88.62%   -0.01%     
===========================================
  Files         2148     2148              
  Lines       398855   398857       +2     
===========================================
- Hits        353480   353476       -4     
- Misses       45375    45381       +6     
Impacted Files Coverage Δ
src/sage/combinat/designs/difference_family.py 88.75% <0.00%> (ø)
src/sage/combinat/integer_vector.py 93.16% <0.00%> (-0.26%) ⬇️
src/sage/schemes/generic/point.py 75.00% <0.00%> (ø)
.../sage/schemes/product_projective/rational_point.py 83.10% <0.00%> (ø)
...hyperelliptic_curves/hyperelliptic_finite_field.py 90.74% <33.33%> (ø)
src/sage/schemes/berkovich/berkovich_space.py 85.03% <50.00%> (ø)
src/sage/schemes/curves/affine_curve.py 83.66% <50.00%> (ø)
src/sage/schemes/hyperelliptic_curves/mestre.py 81.81% <50.00%> (ø)
...c/sage/combinat/finite_state_machine_generators.py 97.57% <80.00%> (ø)
src/sage/schemes/projective/projective_morphism.py 91.01% <85.41%> (+0.01%) ⬆️
... and 16 more

... and 28 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

fchapoton and others added 2 commits March 22, 2023 08:27
@kwankyu
Copy link
Collaborator

kwankyu commented Mar 23, 2023

LGTM.

@vbraun
Copy link
Member

vbraun commented Apr 1, 2023

merge conflict

@vbraun
Copy link
Member

vbraun commented Apr 4, 2023

conflicts with #35314

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 4, 2023

I suggest to rebase onto the next beta.

@fchapoton
Copy link
Contributor Author

setting back to positive after trivial merge

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 0ee39ac

@vbraun vbraun merged commit da8e56d into sagemath:develop Apr 13, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 14, 2023
@fchapoton fchapoton deleted the fix_E502_combinat_schemes branch July 16, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants