ABC for BooleanPolynomialRing
#35240
Conversation
…nomialRing_base (fixup)
| @@ -1,14 +1,13 @@ | |||
| from libcpp.memory cimport unique_ptr, shared_ptr, make_shared | |||
|
|
|||
| from sage.rings.polynomial.multi_polynomial_ring_base cimport \ | |||
| MPolynomialRing_base | |||
| from sage.rings.polynomial.multi_polynomial_ring_base cimport MPolynomialRing_base, BooleanPolynomialRing_base | |||
There was a problem hiding this comment.
Is it still necessary to cimport MPolynomialRing_base? It is the only instance in this file. Do any file importing from sage.rings.polynomial.pbori.pbori expect it? If so, could they import it directly from sage.rings.polynomial.multi_polynomial_ring_base instead?
There was a problem hiding this comment.
It is used in pbori.pyx for an isinstance check
There was a problem hiding this comment.
I can of course move the cimport to the pyx file if you think that's better
There was a problem hiding this comment.
I do not think it is particularly better. A cython expert would have to chime in on that. So, let's leave it as is.
|
I'll let the automated stuff do its bits before approving. |
|
Documentation preview for this PR is ready! 🎉 |
|
Tests pass |
|
Thank you! |
📚 Description
The new ABC
sage.rings.polynomial.multi_polynomial_ring_base.BooleanPolynomialRing_basecan be imported forisinstancetests, without a compile time dependency onbrial.This is a step towards a modularized distribution sagemath-brial.
Part of:
is_Classfunctions, create abstract base classes to enable modularization #32414📝 Checklist
⌛ Dependencies