-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to Weyl character rings #35186
Various improvements to Weyl character rings #35186
Conversation
Documentation preview for this PR is ready! 🎉 |
I built the commit and verified the speedup, which is pretty good if the rank is moderately large. The Demazure character formula is used to compute characters, which also underly the calculations of tensor products. The exception is that for reductive groups that are not semisimple such as GL(r), the Demazure character formula is not used, in lieu of the Freudenthal multiplicity formula. Because of this here is no speedup for WeylCharacterRings in Type A unless you make the WeylCharacterRing with style="coroots" but this is the default for FusionRings. Nothing in the patch would require doctest revisions. I can recommend a positive review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as requested by @tscrim
@dwbump is a member of triage team |
Thank you @dimpase! |
📚 Description
We provide a number of improvements to the Weyl character ring:
_demazure_helper
method by only doing operations based upon the support of the simple roots.~6s
.FusionRing
as a subobject of theWeightRing
.📝 Checklist
⌛ Dependencies