-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activate W293 and E714 in pyx files #35165
activate W293 and E714 in pyx files #35165
Conversation
LGTM. |
Merci David. Faut approuver, je crois, pour que ça soit fusionné. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with these changes
merge conflict |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #35165 +/- ##
===========================================
- Coverage 88.62% 88.60% -0.03%
===========================================
Files 2148 2148
Lines 398855 398855
===========================================
- Hits 353480 353396 -84
- Misses 45375 45459 +84 see 31 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Documentation preview for this PR is ready! 🎉 |
setting back to positive after trivial merge |
Was about to do it. LGTM. |
📚 Description
This fixes and activate the pycodestyle warnings
W293: blank line contains whitespace
and
E714: Test for object identity should be 'is not'
in all .pyx files inside src/sage
📝 Checklist
⌛ Dependencies