Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate W293 and E714 in pyx files #35165

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Feb 20, 2023

📚 Description

This fixes and activate the pycodestyle warnings

W293: blank line contains whitespace

and

E714: Test for object identity should be 'is not'

in all .pyx files inside src/sage

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert
Copy link
Contributor

LGTM.

@fchapoton
Copy link
Contributor Author

Merci David. Faut approuver, je crois, pour que ça soit fusionné.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes

@vbraun
Copy link
Member

vbraun commented Mar 23, 2023

merge conflict

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (fe1e890) 88.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35165      +/-   ##
===========================================
- Coverage    88.62%   88.60%   -0.03%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353396      -84     
- Misses       45375    45459      +84     

see 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: fe1e890

@fchapoton
Copy link
Contributor Author

setting back to positive after trivial merge

@dcoudert
Copy link
Contributor

Was about to do it. LGTM.

@vbraun vbraun merged commit 25a0853 into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
@fchapoton fchapoton deleted the activate_W293_and_E714_in_pyx branch July 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants