Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update normaliz to 3.10.0, update e_antic, pynormaliz #35140

Merged
merged 4 commits into from
Mar 26, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 15, 2023

📚 Description

Upgrade to latest - /~https://github.com/Normaliz/Normaliz/releases/tag/3.10.0

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (52a81cb) 88.57% compared to head (1c0f702) 88.58%.

❗ Current head 1c0f702 differs from pull request most recent head fb2f8f3. Consider uploading reports for the commit fb2f8f3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35140      +/-   ##
===========================================
+ Coverage    88.57%   88.58%   +0.01%     
===========================================
  Files         2140     2140              
  Lines       397273   397273              
===========================================
+ Hits        351891   351938      +47     
+ Misses       45382    45335      -47     

see 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe mkoeppe requested a review from dimpase March 4, 2023 09:34
@dimpase
Copy link
Member

dimpase commented Mar 12, 2023

I'll wait for CI to complete, before doing the review

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: fb2f8f3

@vbraun vbraun merged commit a21293e into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe deleted the normaliz_3_10 branch March 26, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants