Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pep8 E303 in various folders (plot, quadratic forms, etc) #35132

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

This is fixing pep8 warning E303 too many blank lines in several subfolders of src/sage, including plot and quadratic_forms.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 85b1af3

@codecov-commenter
Copy link

Codecov Report

Base: 88.58% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (85b1af3) compared to base (e310936).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35132   +/-   ##
========================================
  Coverage    88.58%   88.59%           
========================================
  Files         2140     2140           
  Lines       396961   396961           
========================================
+ Hits        351657   351681   +24     
+ Misses       45304    45280   -24     
Impacted Files Coverage Δ
src/sage/plot/animate.py 63.14% <ø> (ø)
src/sage/plot/matrix_plot.py 96.18% <ø> (ø)
src/sage/plot/plot.py 86.48% <ø> (ø)
src/sage/plot/plot3d/tri_plot.py 99.07% <ø> (ø)
src/sage/plot/primitive.py 96.87% <ø> (ø)
src/sage/quadratic_forms/constructions.py 88.88% <ø> (ø)
src/sage/quadratic_forms/genera/genus.py 91.45% <ø> (ø)
src/sage/quadratic_forms/quadratic_form.py 90.09% <ø> (ø)
...e/quadratic_forms/quadratic_form__count_local_2.py 100.00% <ø> (ø)
...ratic_forms/quadratic_form__equivalence_testing.py 81.69% <ø> (ø)
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vbraun vbraun merged commit 63ab60d into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
@fchapoton fchapoton deleted the fix_E303_quadratic branch July 16, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants