-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/pkgs/pcre: Remove #35083
build/pkgs/pcre: Remove #35083
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #35083 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.02%
===========================================
Files 2148 2148
Lines 398653 398653
===========================================
- Hits 353308 353258 -50
- Misses 45345 45395 +50 see 31 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
it actually adds |
OK, I've removed the comment |
Thanks, Dima! |
Merge conflict |
9c79963
to
f61e83a
Compare
Documentation preview for this PR is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📚 Description
Remove the spkg
pcre
; it was a dependency of ourr
package, which was reduced to a dummy package recently.Closes #32231
📝 Checklist
⌛ Dependencies