#27428 fix use of sig_on()/sig_off() in CBF.integral()

[mezzarobba]

No description provided.

[codecov-commenter]

Codecov Report

Base: 88.60% // Head: 88.59% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6d2ee48) compared to base (698001b).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35044      +/-   ##
===========================================
- Coverage    88.60%   88.59%   -0.02%     
===========================================
  Files         2136     2136              
  Lines       396141   396142       +1     
===========================================
- Hits        351009   350947      -62     
- Misses       45132    45195      +63     

Impacted Files	Coverage Δ
src/sage/data_structures/stream.py	92.41% <0.00%> (-5.06%)	⬇️
src/sage/interfaces/qsieve.py	71.30% <0.00%> (-2.61%)	⬇️
src/sage/schemes/elliptic_curves/hom_frobenius.py	96.34% <0.00%> (-1.22%)	⬇️
src/sage/interfaces/ecm.py	92.48% <0.00%> (-1.16%)	⬇️
src/sage/modular/hecke/algebra.py	94.65% <0.00%> (-1.07%)	⬇️
src/sage/doctest/forker.py	81.18% <0.00%> (-0.81%)	⬇️
src/sage/modular/modform/numerical.py	94.19% <0.00%> (-0.65%)	⬇️
...sage/geometry/hyperbolic_space/hyperbolic_model.py	88.95% <0.00%> (-0.62%)	⬇️
src/sage/schemes/toric/sheaf/klyachko.py	92.43% <0.00%> (-0.55%)	⬇️
src/sage/sets/integer_range.py	91.41% <0.00%> (-0.51%)	⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mezzarobba]

Tests morally passing

[fchapoton]

looks good to me

[vbraun]

On 32-bit:

**********************************************************************
File "src/sage/combinat/bijectionist.py", line 1578, in sage.combinat.bijectionist.Bijectionist._forced_constant_blocks
Failed example:
    for p in bij.constant_blocks(): print(list(p))
Expected:
    [[2, 1, 3, 4], [1, 2, 4, 3], [1, 3, 2, 4], [4, 2, 3, 1]]
    [[3, 2, 1], [1, 3, 2], [2, 1, 3]]
    [[2, 4, 3, 1], [3, 2, 4, 1], [2, 3, 1, 4], [1, 3, 4, 2]]
    [[1, 4, 2, 3], [3, 1, 2, 4], [4, 2, 1, 3], [4, 1, 3, 2]]
    [[1, 4, 3, 2], [3, 2, 1, 4]]
    [[2, 1, 4, 3], [4, 3, 2, 1]]
    [[2, 4, 1, 3], [3, 4, 2, 1], [4, 3, 1, 2], [3, 1, 4, 2]]
Got:
    [[1, 2, 4, 3], [4, 2, 3, 1], [1, 3, 2, 4], [2, 1, 3, 4]]
    [[2, 1, 3], [3, 2, 1], [1, 3, 2]]
    [[1, 3, 4, 2], [2, 3, 1, 4], [3, 2, 4, 1], [2, 4, 3, 1]]
    [[3, 1, 2, 4], [4, 2, 1, 3], [4, 1, 3, 2], [1, 4, 2, 3]]
    [[3, 2, 1, 4], [1, 4, 3, 2]]
    [[2, 1, 4, 3], [4, 3, 2, 1]]
    [[3, 4, 2, 1], [2, 4, 1, 3], [4, 3, 1, 2], [3, 1, 4, 2]]
**********************************************************************
File "src/sage/combinat/bijectionist.py", line 1587, in sage.combinat.bijectionist.Bijectionist._forced_constant_blocks
Failed example:
    for p in bij.constant_blocks(optimal=True): sorted(p, key=len)
Expected:
    [[1], [1, 2], [1, 2, 3], [1, 2, 3, 4]]
    [[1, 3, 2],
     [2, 1, 3],
     [3, 2, 1],
     [2, 3, 4, 1],
     [1, 3, 4, 2],
     [2, 1, 3, 4],
     [1, 3, 2, 4],
     [2, 3, 1, 4],
     [1, 2, 4, 3],
     [3, 2, 4, 1],
     [2, 1, 4, 3],
     [2, 4, 3, 1],
     [4, 2, 3, 1],
     [4, 3, 2, 1],
     [1, 4, 3, 2],
     [3, 2, 1, 4]]
    [[1, 4, 2, 3],
     [4, 2, 1, 3],
     [2, 4, 1, 3],
     [4, 3, 1, 2],
     [4, 1, 3, 2],
     [3, 4, 2, 1],
     [3, 1, 2, 4],
     [3, 1, 4, 2]]
Got:
    [[1], [1, 2], [1, 2, 3], [1, 2, 3, 4]]
    [[3, 2, 1],
     [1, 3, 2],
     [2, 1, 3],
     [2, 1, 4, 3],
     [1, 3, 2, 4],
     [2, 4, 3, 1],
     [1, 3, 4, 2],
     [2, 3, 1, 4],
     [3, 2, 1, 4],
     [4, 2, 3, 1],
     [1, 4, 3, 2],
     [2, 1, 3, 4],
     [1, 2, 4, 3],
     [3, 2, 4, 1],
     [4, 3, 2, 1],
     [2, 3, 4, 1]]
    [[3, 1, 2, 4],
     [4, 1, 3, 2],
     [4, 3, 1, 2],
     [1, 4, 2, 3],
     [3, 4, 2, 1],
     [4, 2, 1, 3],
     [2, 4, 1, 3],
     [3, 1, 4, 2]]
**********************************************************************
1 item had failures:
   2 of  65 in sage.combinat.bijectionist.Bijectionist._forced_constant_blocks
    [579 tests, 2 failures, 69.84 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/combinat/bijectionist.py  # 2 doctests failed
----------------------------------------------------------------------

[mkoeppe]

@vbraun Very unlikely that this failure is coming from this PR!

[mkoeppe]

Probably nondeterministic sort order in #35060, which added this test

[vbraun]

yep wrong ticket ;)