-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trac role to GitHub #35015
Trac role to GitHub #35015
Conversation
How about introducing a new role We may keep both for some time. |
Maybe a general purpose |
Never in a few years :-) Like |
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35015 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.02%
===========================================
Files 2140 2140
Lines 396961 396958 -3
===========================================
- Hits 351677 351634 -43
- Misses 45284 45324 +40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry about that; I had meant to just avoid the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
there is still a number of explicit (rewritten to URLs) trac.sagemath.org/ticket/<...> links in docstrings which should become :trac: |
Documentation preview for this PR is ready! 🎉 |
@vbraun - can you merge this soon? It's touching a lo of files for a good reason, and having it linger on |
I think the best way to request this is to mark with a high-priority label |
Taken from #34816. This is necessary when system numpy is 1.24, and a prerequiste to update numpy in sagemath. It's probably safer at this time to merge this and leave the update for next release. Testing: void-linux/void-packages#42048 Depends on #35015 URL: #34994 Reported by: Gonzalo Tornaría Reviewer(s): Matthias Köppe, Volker Braun
As part of the transition to github, this PR removes some references to the trac server from the Sage source. ### 📚 Description I split off this PR from the main effort at #35015 since I wasn't sure what to do with some checksum links. After some discussion, @dimpase and @mkoeppe noted that the links could just be deleted. This PR will fix #35014. URL: #35023 Reported by: roed314 Reviewer(s): Dima Pasechnik
📚 Description
Changes the
:trac:
role to point to github instead, and changes deprecation and stopgap warnings. Changes all the resulting urls that are printed in doctests, as well as various comments in code.Does not update the developer documentation to explain how to use github.