-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve camera positioning for threejs #34960
Improve camera positioning for threejs #34960
Conversation
I cannot apply labels. |
I just added a label (but I have more rights). You don't see a list when you click on the wheel, or you do see them, but can't added them? |
I'm really not sure why you can't do anything with labels - according to GitHub docs, it does not need more permissions than you already have: https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels |
oops, sorry, you need a "triage access" to repo to apply labels: |
Codecov ReportBase: 88.59% // Head: 88.59% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #34960 +/- ##
===========================================
- Coverage 88.59% 88.59% -0.01%
===========================================
Files 2136 2136
Lines 396141 396141
===========================================
- Hits 350964 350963 -1
- Misses 45177 45178 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What the hell is this Codecov comment? Spammer already? |
I don't see the wheel. |
Codecov ReportBase: 88.59% // Head: 88.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #34960 +/- ##
========================================
Coverage 88.59% 88.59%
========================================
Files 2136 2136
Lines 396142 396141 -1
========================================
+ Hits 350948 350970 +22
+ Misses 45194 45171 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This "Codecov Report" is extravagant. I wish that that is moved to the checks, somehow. |
Documentation preview for this PR is ready! 🎉 |
How can this be reviewed? Is this visible somewhere in the docs? |
No. We should see interactive 3d graphics "before the branch" and "after the branch". |
As the code is small, you may copy and paste the code directly into your local develop branch, and test the example The example is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I tried the snippet provided, all good.
Thank you! |
Fixes #34822.
The template says that we are not yet accepting PRs. But I will just go ahead.