Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve camera positioning for threejs #34960

Merged
merged 5 commits into from
Feb 19, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Feb 6, 2023

Fixes #34822.

The template says that we are not yet accepting PRs. But I will just go ahead.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 6, 2023

I cannot apply labels.

@dimpase
Copy link
Member

dimpase commented Feb 6, 2023

I just added a label (but I have more rights).

You don't see a list when you click on the wheel, or you do see them, but can't added them?

@dimpase
Copy link
Member

dimpase commented Feb 6, 2023

I'm really not sure why you can't do anything with labels - according to GitHub docs, it does not need more permissions than you already have: https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels

@dimpase
Copy link
Member

dimpase commented Feb 6, 2023

oops, sorry, you need a "triage access" to repo to apply labels:
https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels

@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a80f14a) compared to base (200557e).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34960      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2136     2136              
  Lines       396141   396141              
===========================================
- Hits        350964   350963       -1     
- Misses       45177    45178       +1     
Impacted Files Coverage Δ
src/sage/homology/matrix_utils.py 87.15% <0.00%> (-0.92%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.90%) ⬇️
src/sage/combinat/posets/poset_examples.py 87.67% <0.00%> (-0.86%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 95.27% <0.00%> (-0.79%) ⬇️
src/sage/categories/weyl_groups.py 96.47% <0.00%> (-0.59%) ⬇️
src/sage/matrix/matrix_integer_dense_hnf.py 85.71% <0.00%> (-0.51%) ⬇️
src/sage/graphs/tutte_polynomial.py 93.57% <0.00%> (-0.46%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
src/sage/crypto/sboxes.py 96.17% <0.00%> (-0.28%) ⬇️
src/sage/doctest/forker.py 81.72% <0.00%> (-0.27%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 6, 2023

What the hell is this Codecov comment? Spammer already?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 6, 2023

You don't see a list when you click on the wheel, or you do see them, but can't added them?

I don't see the wheel.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 88.59% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (aa9937b) compared to base (104dde9).
Patch has no changes to coverable lines.

❗ Current head aa9937b differs from pull request most recent head 23e35c0. Consider uploading reports for the commit 23e35c0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34960   +/-   ##
========================================
  Coverage    88.59%   88.59%           
========================================
  Files         2136     2136           
  Lines       396142   396141    -1     
========================================
+ Hits        350948   350970   +22     
+ Misses       45194    45171   -23     
Impacted Files Coverage Δ
src/sage/rings/polynomial/pbori/parallel.py 59.82% <0.00%> (-1.79%) ⬇️
src/sage/modular/arithgroup/congroup_gamma0.py 94.41% <0.00%> (-0.56%) ⬇️
src/sage/graphs/generic_graph.py 89.14% <0.00%> (-0.40%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.40%) ⬇️
...aphs/graph_decompositions/modular_decomposition.py 88.82% <0.00%> (-0.29%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 67.12% <0.00%> (-0.20%) ⬇️
src/sage/modular/modsym/ambient.py 92.53% <0.00%> (-0.11%) ⬇️
src/sage/sandpiles/sandpile.py 90.92% <0.00%> (-0.07%) ⬇️
src/sage/schemes/elliptic_curves/ell_point.py 84.61% <0.00%> (-0.02%) ⬇️
src/sage/numerical/interactive_simplex_method.py 91.84% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 8, 2023

This "Codecov Report" is extravagant. I wish that that is moved to the checks, somehow.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 952a6c9

@dimpase
Copy link
Member

dimpase commented Feb 18, 2023

How can this be reviewed? Is this visible somewhere in the docs?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 18, 2023

No. We should see interactive 3d graphics "before the branch" and "after the branch".

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 18, 2023

As the code is small, you may copy and paste the code directly into your local develop branch, and test the example
in the linked issue. No need to compile anything.

The example is

var('x,y,z')
implicit_plot3d((sqrt(x*x+y*y)-3)^2 + z*z - 1, (x,-4,4), (y,-4,4), (z,-1,1))

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I tried the snippet provided, all good.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 18, 2023

Thank you!

@vbraun vbraun merged commit 8e038e1 into sagemath:develop Feb 19, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Feb 19, 2023
@kwankyu kwankyu deleted the fix/34822/better-position-camera branch August 24, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better position the camera in 3d graphics
5 participants