Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around an Android emulator bug(?) #1036

Merged
merged 1 commit into from
Jun 27, 2018

Conversation

SimonSapin
Copy link
Contributor

Do not pass a CONTEXT_FLAGS_KHR attribute to egl.CreateContext when it is at the default value.

@SimonSapin
Copy link
Contributor Author

For posterity: this is with emulator version 27.2.9 started with -gpu guest running on Linux with the image system-images;android-28;google_apis;x86e. (This is the only config where I was able to get GLES3 support on Linux, so far.)

@francesca64
Copy link
Member

This looks alright to me (though I still need to actually test it), but I'd like a CHANGELOG entry.

@SimonSapin
Copy link
Contributor Author

Sure. Should the entry describe the change factually, or its goal? In how much detail?

@francesca64
Copy link
Member

winit's CHANGELOG is the closest thing I have to a style guide, though I admit I should really make a CONTRIBUTING that explains this.

Generally speaking, the entry shouldn't include implementation details, and should just concern the practical impact on application developers. In this case, enough information that someone who's encountered this issue before would recognize that it's been fixed.

@SimonSapin
Copy link
Contributor Author

Sounds good, added.

@francesca64
Copy link
Member

Thanks!

@francesca64 francesca64 merged commit 0c3fbdd into rust-windowing:master Jun 27, 2018
@SimonSapin SimonSapin deleted the CONTEXT_FLAGS_KHR branch June 28, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants