Fix float NaN positive/negative assumptions #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
commented
Jul 8, 2017
traits/src/float.rs
Outdated
| /// Returns `true` if `self` is positive, including `+0.0` and | ||
| /// `Float::infinity()`. | ||
| /// Returns `true` if `self` is positive, including `+0.0`, | ||
| /// `Float::infinity()`, and `f64::NAN` with newer versions of Rust. |
There was a problem hiding this comment.
Any ideas on how to make this less confusing? Right now it's not clear what "newer versions of Rust" applies to.
There was a problem hiding this comment.
NVM ".., and with newer versions of Rust f64::NAN" works.
cuviper
requested changes
Jul 9, 2017
traits/src/float.rs
Outdated
| @@ -337,27 +337,25 @@ pub trait Float | |||
| /// | |||
| /// assert!(f.is_sign_positive()); | |||
| /// assert!(!g.is_sign_positive()); | |||
| /// // Requires both tests to determine if is `NaN` | |||
| /// assert!(!nan.is_sign_positive() && !nan.is_sign_negative()); | |||
| /// assert!(!nan.is_sign_negative()); | |||
There was a problem hiding this comment.
Hmm, we should be testing fn is_sign_positive() here, but I realize older rust won't return true. Perhaps this one should check !neg_nan.is_sign_positive().
traits/src/float.rs
Outdated
| /// | ||
| /// let f = 7.0; | ||
| /// let g = -7.0; | ||
| /// | ||
| /// assert!(!f.is_sign_negative()); | ||
| /// assert!(g.is_sign_negative()); | ||
| /// // Requires both tests to determine if is `NaN`. | ||
| /// assert!(!nan.is_sign_positive() && !nan.is_sign_negative()); | ||
| /// assert!(!neg_nan.is_sign_positive()); |
There was a problem hiding this comment.
And this doctest should have the !nan.is_sign_negative().
|
Thanks! I'm not sure if the bot will work since it's not on your branch yet, but let's try: bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the minimal assumptions to make about
NaN. Fixes part of #312 (but not thenextbranch).