Remove itertools as a dependency #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
commented
Sep 25, 2019
bluss
force-pushed
the
remove-itertools
branch
from
46478d1 to
e9cf623
Compare
|
It's no major thing, but looking at it, we didn't use much of itertools, and removing it speeds up the build by a tiny amount and removes itertools and either from the default dependency tree. Objectively they contain a lot of code that we are not using. I guess the only debatable thing, is the validity of copying code instead of reusing, no matter how small that code piece is? cc #723 |
We use `izip!()` as the only major feature from itertools, and can remove it to save build time and two small crates as deps. `izip!()` is license compatible and originally written by @krdln (Michał Krasnoborski) and @bluss in itertools, so we copy it into the crate. The free functions zip(i, j) and enumerate(i) are just style preferences, written by me, and simple to copy. Itertools is still used as a dev-dependency.
bluss
force-pushed
the
remove-itertools
branch
from
e9cf623 to
ec2fb66
Compare
|
I haven't had a chance to review this PR in detail, but I do think it's a good idea, considering how little code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
izip!()as the only major feature from itertools, and canremove it to save build time and two small crates as deps.
izip!()is license compatible and originally written by @krdln(Michał Krasnoborski) and @bluss in itertools, so we copy it into the
crate.
The free functions zip(i, j) and enumerate(i) are just style
preferences, written by me, and simple to copy.
Itertools is still used as a dev-dependency.