Update to quickcheck 1.0 #1114
Merged
Update to quickcheck 1.0 #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
force-pushed
the
qc-1
branch
4 times, most recently
from
34603da to
d0f7499
Compare
New in 1.0 is that integers now generate values in their whole range. That creates a different situation for the tests taking isize than before. Shrink their accepted values for now, and leave as fixmes to investigate and improve. In some cases, the tests are slow to execute. In other cases, the tests fail with large values (probably overflow), and following that, the case shrinking is extremely slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New in 1.0 is that integers now generate values in their whole range.
That creates a different situation for the tests taking isize than
before.
Shrink their accepted values for now, and leave as fixmes to investigate and
improve.
In some cases, the tests are slow to execute.
In other cases, the tests fail with large values (probably overflow),
and following that, the case shrinking is extremely slow.