Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DONE) needs triage: misc failures and diagnostics issues #148

Closed
lcnr opened this issue Jan 21, 2025 · 0 comments
Closed

(DONE) needs triage: misc failures and diagnostics issues #148

lcnr opened this issue Jan 21, 2025 · 0 comments

Comments

@lcnr
Copy link
Contributor

lcnr commented Jan 21, 2025

All issues have been triaged and moved into appropriate sub issues :3

@lcnr lcnr changed the title misc failures and diagnostics issues TODO(@lcnr): misc failures and diagnostics issues Jan 21, 2025
@lcnr lcnr changed the title TODO(@lcnr): misc failures and diagnostics issues misc failures and diagnostics issues Jan 21, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 22, 2025
…ls, r=lcnr

Don't pick `T: FnPtr` nested goals as the leaf goal in diagnostics for new solver

r? `@lcnr`

See `tests/ui/traits/next-solver/diagnostics/dont-pick-fnptr-bound-as-leaf.rs` for a minimized example of what code this affects the diagnostics off. The output of running nightly `-Znext-solver` on that test is the following:
```
error[E0277]: the trait bound `Foo: Trait` is not satisfied
  --> src/lib.rs:14:20
   |
14 |     requires_trait(Foo);
   |     -------------- ^^^ the trait `FnPtr` is not implemented for `Foo`
   |     |
   |     required by a bound introduced by this call
   |
note: required for `Foo` to implement `Trait`
  --> src/lib.rs:7:16
   |
7  | impl<T: FnPtr> Trait for T {}
   |         -----  ^^^^^     ^
   |         |
   |         unsatisfied trait bound introduced here
note: required by a bound in `requires_trait`
  --> src/lib.rs:11:22
   |
11 | fn requires_trait<T: Trait>(_: T) {}
   |                      ^^^^^ required by this bound in `requires_trait`
```

Part of rust-lang/trait-system-refactor-initiative#148
@lcnr lcnr changed the title misc failures and diagnostics issues needs triage: misc failures and diagnostics issues Jan 29, 2025
@lcnr lcnr moved this to unknown in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr moved this from unknown to todo in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr closed this as completed by moving to todo in -Znext-solver=globally Jan 29, 2025
@github-project-automation github-project-automation bot moved this from unknown to todo in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr moved this from todo to unknown in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr moved this from todo to unknown in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr reopened this Jan 29, 2025
@lcnr lcnr moved this from unknown to in progress in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr moved this from in progress to unknown in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr moved this from unknown to toduu in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr closed this as completed by moving to toduu in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr moved this from toduu to todo in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr reopened this Jan 29, 2025
@lcnr lcnr moved this from todo to unknown in -Znext-solver=globally Jan 29, 2025
@lcnr lcnr changed the title needs triage: misc failures and diagnostics issues (DONE) needs triage: misc failures and diagnostics issues Feb 18, 2025
@lcnr lcnr closed this as completed Feb 18, 2025
@lcnr lcnr moved this from unknown to done in -Znext-solver=globally Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant