Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix consists in removing the call to
generics_shape_from_config
which was indenting generics unnecessarily regardless of thehard_tabs
option. TheVisual
indent style was also adding 2 leading whitespaces which seemed odd; below is a diff of the two formatting versions.Are the 2 leading whitespaces added on purpose ? Is it OK to remove them ?
Close #3840