Update to last Emitter update #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topecongiro
reviewed
Oct 20, 2017
src/lib.rs
Outdated
| @@ -510,6 +510,7 @@ pub fn format_input<T: Write>( | |||
| let silent_emitter = Box::new(EmitterWriter::new( | |||
| Box::new(Vec::new()), | |||
| Some(codemap.clone()), | |||
| false, | |||
There was a problem hiding this comment.
Could you please fix the indentation here?
|
Created emitter branch. |
GuillaumeGomez
force-pushed
the
emitter
branch
from
e74b61c to
e35e276
Compare
|
Thanks! (and updated) |
|
The corresponding rust PR has been merged so tests should be working back again in here. Once this PR merged, I'll re-enable rustfmt in the compiler. |
|
There hasn't been a new nightly for a few days. I guess we have to wait for that to get fixed before doing anything here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for this PR.
However, this'll break until the mentionned PR gets merged, and the mentionned PR requires this one to be merged otherwise tests won't pass. So much fun. :)