Rollup of 5 pull requests #97304
Merged
Rollup of 5 pull requests #97304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While already being inferable from the doc examples, it wasn't fully specified. This is the only logical way to do a slice iterator.
…rder, r=dtolnay Clarify slice and Vec iteration order While already being inferable from the doc examples, it wasn't fully specified. This is the only logical way to do a slice iterator, so I think this should be uncontroversial. It also improves the `Vec::into_iter` example to better show the order and that the iterator returns owned values.
Remove feature: `crate` visibility modifier FCP completed in rust-lang#53120.
…rrors Add regression test for rust-lang#91949 Closes rust-lang#91949 This needs `build-fail` because the original bug only appeared with `cargo build`. r? `@compiler-errors`
std::time : fix variable name in the doc
Fix some typos in arg checking algorithm Fixes rust-lang#97197 Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit b5ff4ad has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (9e2f655): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
cratevisibility modifier #97254 (Remove feature:cratevisibility modifier)overflowerror. #91949)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup