-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #91486
Rollup of 10 pull requests #91486
Conversation
# Conflicts: # Configurations.md
* Add a few missing tracking issues in Configurations.md * fix: tracking issue for imports_granularity stabilization Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
Prevents wrap_comments from incorrectly wrapping reference-style doc links.
Don't preload italic font faces because they aren't used on all pages, and when they are used, they are used sparingly so it's okay if they are slower to load.
Use the available Generics span field to avoid issues with `T: Fn()` bounds. This is necessary to land rust-lang#85346.
Adds the ``nightly_only_test`` and ``stable_only_test`` attribute macros that prevent or allow certain tests to compile on nightly and stable respectively. This is achieved through conditionally outputting the tests TokenStream. If CFG_RELEASE_CHANNEL is not set, it's assumed that we're running in a nightly environment. To mark a test as nightly only: #[nightly_only_test] #[test] fn only_run_on_nightly() { ... } To mark a test a stable only: #[stable_only_test] #[test] fn only_run_on_stable() { ... }
Fixes 5088 Previously, rustfmt would add a new comment line anytime it reformatted an itemized block within a comment when ``wrap_comments=true``. This would lead to rustfmt adding empty comments with trailing whitespace. Now, new comment lines are only added if the original comment spanned multiple lines, if the comment needs to be wrapped, or if the comment originally started with an empty comment line.
This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.
Other targets allow this function to be unused, DragonFly just misses out due to providing a specialization.
…021-12-02 subtree sync
…tolnay Implement write() method for Box<MaybeUninit<T>> This adds method similar to `MaybeUninit::write` main difference being it returns owned `Box`. This can be used to elide copy from stack safely, however it's not currently tested that the optimization actually occurs. Analogous methods are not provided for `Rc` and `Arc` as those need to handle the possibility of sharing. Some version of them may be added in the future. This was discussed in rust-lang#63291 which this change extends.
Make `Option::expect` unstably const Tracking issue: rust-lang#67441
…olnay Document Windows TLS drop behaviour The way Windows TLS destructors are run has some "interesting" properties. They should be documented. Fixes rust-lang#74875
…egions, r=jackh726 Use try_normalize_erasing_regions in needs_drop Fixes rust-lang#81199 r? ``@jackh726``
suppress warning about set_errno being unused on DragonFly Other targets allow this function to be unused, DragonFly just misses out due to providing a specialization. This fixes a build error for DragonFly.
…e, r=calebcartwright Sync rustfmt subtree
@bors r+ rollup=never p=10 |
📌 Commit a216060 has been approved by |
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88906 (Implement write() method for Box<MaybeUninit<T>>) - rust-lang#90269 (Make `Option::expect` unstably const) - rust-lang#90854 (Type can be unsized and uninhabited) - rust-lang#91170 (rustdoc: preload fonts) - rust-lang#91273 (Fix ICE rust-lang#91268 by checking that the snippet ends with a `)`) - rust-lang#91381 (Android: -ldl must appear after -lgcc when linking) - rust-lang#91453 (Document Windows TLS drop behaviour) - rust-lang#91462 (Use try_normalize_erasing_regions in needs_drop) - rust-lang#91474 (suppress warning about set_errno being unused on DragonFly) - rust-lang#91483 (Sync rustfmt subtree) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
☀️ Test successful - checks-actions |
Did bors hiccup here? I think it's complaining that merged PRs are now conflicting with themselves? |
This has been merged into master, but GitHub didn't detect it for whatever reason. Closing. |
Finished benchmarking commit (3e21768): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
@matthiaskrgr this seems to hurt match expression compilation performance, but none of the individual PRs strike me as being a culprit. We'll likely want to run cachegrind to see what we find, but I unfortunately don't have time for that right now. |
Successful merges:
Option::expect
unstably const #90269 (MakeOption::expect
unstably const))
#91273 (Fix ICE ICE: string indexed not at a char boundary when constructing error message #91268 by checking that the snippet ends with a)
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup