-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider unfulfilled obligations in binop errors #89323
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a44c45ad10fb8966b70277036614fc7816f9cba0 with merge 5971dfc06e85c9854f851f945da5040e0b31ba48... |
☀️ Try build successful - checks-actions |
Queued 5971dfc06e85c9854f851f945da5040e0b31ba48 with parent 50f9f78, future comparison URL. |
Finished benchmarking commit (5971dfc06e85c9854f851f945da5040e0b31ba48): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4d55ff29e5b641a20091ca8888ab129c192e6574 with merge 0cf952227f02aa71d77879ef66bbb3d1a477c9c2... |
@petrochenkov, sorry I hadn't realized we changed the |
I set the label after writing #89323 (comment) and before the last commit appeared, now it's waiting on perf, I guess. |
Queued dac9ca84fd7135880faa8885c21db395c7841a6e with parent c02371c, future comparison URL. |
Finished benchmarking commit (dac9ca84fd7135880faa8885c21db395c7841a6e): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
b1b3812
to
090cbb0
Compare
This comment has been minimized.
This comment has been minimized.
r=me with commits squashed. |
When encountering a binop where the types would have been accepted, if all the predicates had been fulfilled, include information about the predicates and suggest appropriate `#[derive]`s if possible. Point at trait(s) that needs to be `impl`emented.
@bors r=petrochenkov |
📌 Commit e8fc076 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d7539a6): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
When encountering a binop where the types would have been accepted, if
all the predicates had been fulfilled, include information about the
predicates and suggest appropriate
#[derive]
s if possible.Fix #84515.