-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest both of immutable and mutable trait implementations #89263
Suggest both of immutable and mutable trait implementations #89263
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
2dd6d88
to
e2aad3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, just left a couple of nitpicks.
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
@bors r+ |
📌 Commit 3bab363 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3e8f32e): comparison url. Summary: This change led to large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
@TaKO8Ki @estebank The regression occurs in |
I don't know when |
Maybe LLVM is making different inlining decisions or something? |
closes #85865