Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Explanation For Error E0772 #88205

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Add Explanation For Error E0772 #88205

merged 1 commit into from
Jan 29, 2022

Conversation

danii
Copy link
Contributor

@danii danii commented Aug 21, 2021

I've added an error explanation for the error code E0772.

Assists with #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@danii
Copy link
Contributor Author

danii commented Aug 21, 2021

@rustbot label +S-waiting-on-author -S-waiting-on-review

I can't get tests to work on my machine right now, I'll fix this later today probably

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2021
@GuillaumeGomez
Copy link
Member

No worries, whenever you have the time. Ping me once it's updated so I can review.

@nagisa
Copy link
Member

nagisa commented Aug 23, 2021

r? @GuillaumeGomez

@danii danii requested a review from GuillaumeGomez August 26, 2021 23:49
@danii
Copy link
Contributor Author

danii commented Aug 26, 2021

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@danii
Copy link
Contributor Author

danii commented Aug 27, 2021

Ah. Is using hashtags to hide code fine?

@GuillaumeGomez
Copy link
Member

Ah. Is using hashtags to hide code fine?

Yes it is.

@bors
Copy link
Contributor

bors commented Sep 1, 2021

☔ The latest upstream changes (presumably #88556) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 13, 2021
@JohnCSimon
Copy link
Member

triage:
@danii Can you please address the merge conflict?

@joelpalmer joelpalmer removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2021
@joelpalmer joelpalmer added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2021
@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
GuillaumeGomez
GuillaumeGomez reviewed Oct 27, 2021
View reviewed changes
compiler/rustc_error_codes/src/error_codes.rs Outdated
@@ -5,7 +5,7 @@
// /!\ IMPORTANT /!\
//
// Error messages' format must follow the RFC 1567 available here:
// /~https://github.com/rust-lang/rfcs/pull/1567
// /~https://github.com/rust-lang/rfcs/blob/master/text/1567-long-error-codes-explanation-normalization.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change that, or at least not part of this PR.

GuillaumeGomez
GuillaumeGomez reviewed Oct 27, 2021
View reviewed changes
compiler/rustc_error_codes/src/error_codes/E0772.md Outdated
@@ -0,0 +1,87 @@
A pointer to a trait object has some specific lifetime `'1`, but the trait
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking about pointers here is a bit off the plate and introduce unneeded complexity in my opinion.

GuillaumeGomez
GuillaumeGomez reviewed Oct 27, 2021
View reviewed changes
compiler/rustc_error_codes/src/error_codes/E0772.md Outdated
```

The trait object `person` in the function `get_is_cool`, while already being
behind a pointer with lifetime `'p`, also has it's own lifetime, `'2`.
Copy link
Member

@GuillaumeGomez GuillaumeGomez Oct 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using "pointer" instead of "reference", then please replace pointer with reference.

@JohnCSimon
Copy link
Member

JohnCSimon commented Nov 14, 2021 •
edited
Loading

triage:
@danii Can you please address the comments from GuillaumeGomez and
adjust the label with @rustbot ready when you're ready for review?

@danii
Copy link
Contributor Author

danii commented Jan 28, 2022

Hello, it has been a while. I apologize for my procrastination, I know it's not professional.
Alas, actions are better than words! Hopefully this all fixes it.
I will be making an ongoing effort to resolve all my pull requests from now on. :)

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2022
@GuillaumeGomez
Copy link
Member

The CI error is because of #93384 so let's see approve it. Thanks for working on this!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 29, 2022

📌 Commit 4f8b9a4 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2022
@bors
Auto merge of rust-lang#93457 - matthiaskrgr:rollup-e43ry1l, r=matthi…
a00e130 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88205 (Add Explanation For Error E0772)
 - rust-lang#92274 (Add `intrinsics::const_deallocate`)
 - rust-lang#93236 (Make `NonNull::new` `const`)
 - rust-lang#93299 (Fix dot separator when there is no source link)
 - rust-lang#93410 (kmc-solid: Implement `net::FileDesc::duplicate`)
 - rust-lang#93424 (fix nit)
 - rust-lang#93431 (remove unused `jemallocator` crate)
 - rust-lang#93453 (Add GUI theme change test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 11898a5 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.