Enable --all-targets for x.py check unconditionally
#88011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-contributor-roadblock
Now that Cargo deduplicates diagnostics from different targets, this doesn't flood the console with duplicate errors. Note that this doesn't add `--all-targets` in `Builder::cargo` directly because `impl Step for Std` actually wants to omit `--all-targets` the first time while it's still building libtest. When passed `--all-targets`, this warns that the option isn't needed, but still continues to compile.
jyn514
force-pushed
the
check-all-targets
branch
from
7dbef62 to
c6f4eed
Compare
|
@bors r+ rollup |
|
📌 Commit c6f4eed has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Aug 16, 2021
…mulacrum Enable `--all-targets` for `x.py check` unconditionally Now that Cargo deduplicates diagnostics from different targets, this doesn't flood the console with duplicate errors. Note that this doesn't add `--all-targets` in `Builder::cargo` directly because `impl Step for Std` actually wants to omit `--all-targets` the first time while it's still building libtest. When passed `--all-targets`, this warns that the option isn't needed, but still continues to compile. Fixes rust-lang#87846. r? `@Mark-Simulacrum`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#87178 ([rustdoc] Copy only item path to clipboard rather than full `use` statement.) - rust-lang#87677 (Adding explicit notice of lack of documentation for Tier 2 Platforms) - rust-lang#87958 (Closure migration multispan suggestions) - rust-lang#87967 (Detect fake spans in non_fmt_panic lint.) - rust-lang#88011 (Enable `--all-targets` for `x.py check` unconditionally) - rust-lang#88030 (Assign FIXMEs to me and remove obsolete ones) - rust-lang#88052 (Update redox_syscall) - rust-lang#88055 (Update RELEASES.md for 1.55.0) - rust-lang#88080 (Skip assert ICE with default_method_body_is_const) - rust-lang#88089 (Rustdoc font test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Cargo deduplicates diagnostics from different targets, this doesn't flood the console with
duplicate errors.
Note that this doesn't add
--all-targetsinBuilder::cargodirectly becauseimpl Step for Stdactually wants to omit
--all-targetsthe first time while it's still building libtest.When passed
--all-targets, this warns that the option isn't needed, but still continues to compile.Fixes #87846.
r? @Mark-Simulacrum