Fix double warning about illegal floating-point literal pattern #86888
Conversation
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| span, | ||
| |lint| lint.build("floating-point types cannot be used in patterns").emit(), | ||
| ); | ||
| if self.include_lint_checks { |
There was a problem hiding this comment.
This isn't really new to this PR, but it would be nice if include_lint_checks had some documentation on when it's enabled and when not. Currently it seems to be enabled in rustc_mir_build::thir::pattern::MatchVisitor::lower_pattern but not in rustc_mir_build::thir::pattern::pat_from_hir. lower_pattern happens when checking the validity of matches and pat_from_hir happens when actually constructing mir. It might be nice to mention at the field definition site that include_lint_checks will be true when checking validity and false when building mir.
There was a problem hiding this comment.
It seems somewhat wasteful that the ConstToPat lowering even has to run twice (if it didn't, we wouldn't need the include_lint_checks field). However, I don't know the broader design considerations behind all of this, I just developed a targeted fix for the issue you reported, so I'm not the right person to ask for additional documentation here...
|
@bors r+ |
|
📌 Commit d019c71 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This PR fixes #86600. The problem is that the
ConstToPatstruct contains a fieldinclude_lint_checks, which determines whether lints should be emitted or not, but this field is currently not obeyed at one point, leading to a warning being emitted more than once. I have fixed this behavior here.