Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long explanation for E0545 #82161

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Add long explanation for E0545 #82161

merged 1 commit into from
Feb 16, 2021

Conversation

jesusprubio
Copy link
Contributor

Helps with #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2021
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Feb 15, 2021

📌 Commit 8192793 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 16, 2021
…545, r=GuillaumeGomez

Add long explanation for E0545

Helps with rust-lang#61137
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 16, 2021
…545, r=GuillaumeGomez

Add long explanation for E0545

Helps with rust-lang#61137
fn _unstable_const_fn() {}
```

To fix this issue, you need to provide a correct value in the `issue` field.
Copy link
Contributor

@pickfire pickfire Feb 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To fix this issue, you need to provide a correct value in the `issue` field.
To fix this, provide non-zero numeric string or "none" in the `issue` field.

Maybe we can simplify it?

If the correct value is exhaustive, maybe we can talk about it here.

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2021
…laumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#82145 (Fix ES5 errors (IE11))
 - rust-lang#82160 (Fix typo in rustc_infer::infer::UndoLog)
 - rust-lang#82161 (Add long explanation for E0545)
 - rust-lang#82163 (avoid full-slicing slices)
 - rust-lang#82175 (validation: fix invalid-fn-ptr error message)
 - rust-lang#82184 ([Minor] Update discriminant_value docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cdab137 into rust-lang:master Feb 16, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants