Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch query descriptions to just String #81901

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

Mark-Simulacrum
Copy link
Member

In practice we never used the borrowed variant anyway.

In practice we never used the borrowed variant anyway.
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2021
@bors
Copy link
Contributor

bors commented Feb 8, 2021

⌛ Trying commit f564d7a with merge ec1a063060c724397e9201b90955b36831056a3f...

@bors
Copy link
Contributor

bors commented Feb 8, 2021

☀️ Try build successful - checks-actions
Build commit: ec1a063060c724397e9201b90955b36831056a3f (ec1a063060c724397e9201b90955b36831056a3f)

@rust-timer
Copy link
Collaborator

Queued ec1a063060c724397e9201b90955b36831056a3f with parent 921ec4b, future comparison URL.

@jackh726
Copy link
Member

jackh726 commented Feb 9, 2021

r? @jackh726

r=me if perf is good or neutral

@rust-highfive rust-highfive assigned jackh726 and unassigned davidtwco Feb 9, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (ec1a063060c724397e9201b90955b36831056a3f): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 9, 2021
@Mark-Simulacrum
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Feb 9, 2021

📌 Commit f564d7a has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2021
@bors
Copy link
Contributor

bors commented Feb 9, 2021

⌛ Testing commit f564d7a with merge 36931ce...

@bors
Copy link
Contributor

bors commented Feb 9, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 36931ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 9, 2021
@bors bors merged commit 36931ce into rust-lang:master Feb 9, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants