-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch query descriptions to just String #81901
Conversation
In practice we never used the borrowed variant anyway.
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit f564d7a with merge ec1a063060c724397e9201b90955b36831056a3f... |
☀️ Try build successful - checks-actions |
Queued ec1a063060c724397e9201b90955b36831056a3f with parent 921ec4b, future comparison URL. |
r? @jackh726 r=me if perf is good or neutral |
Finished benchmarking try commit (ec1a063060c724397e9201b90955b36831056a3f): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r=jackh726 |
📌 Commit f564d7a has been approved by |
☀️ Test successful - checks-actions |
In practice we never used the borrowed variant anyway.