-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compiler_builtins
to 0.1.39
#79863
Conversation
r? @Amanieu |
Assembly code in compiler-builtins needs to be switched to use AT&T syntax since Intel syntax doesn't work on the old LLVM (8.0) used in CI. |
Failed on tidy but seems rust-lang/compiler-builtins#396 works fine anyway. @Amanieu Sorry for requesting twice but could you make a new release? I think we can go ahead now. |
Are you sure? The main CI job got canceled when tidy failed. |
Yeah, let's check the CI log:
So the previous failure should be fixed and I think it's worth giving it a try. |
Published 0.1.38 |
5696989
to
fb8544b
Compare
compiler_builtins
to 0.1.37compiler_builtins
to 0.1.38
Thanks! Now CI is green. |
@bors r+ |
📌 Commit fb8544b has been approved by |
Update `compiler_builtins` to 0.1.38 This version contains the fixes of rust-lang/compiler-builtins#390 and rust-lang/compiler-builtins#391. Also, rename features following rust-lang/compiler-builtins#386.
Failed in /~https://github.com/rust-lang-ci/rust/runs/1543672364:
@bors r- |
I removed |
fb8544b
to
d3658f9
Compare
Let's check the build on dist-various-1 and dist-various-2. |
⌛ Trying commit d3658f94a2f8b2d5f94da82dab6e194ced620ec8 with merge 2cc9d2db553df186a9796bc96745974a3fae2bf3... |
☀️ Try build successful - checks-actions |
The try build is green, I think we could give it another try (and it lands hopefully) @Amanieu. Thanks @AaronKutch for fixing it. |
@bors r+ |
📌 Commit d3658f94a2f8b2d5f94da82dab6e194ced620ec8 has been approved by |
@bors r- Oops, need to publish a new release first. |
Published 0.1.39 |
compiler_builtins
to 0.1.38compiler_builtins
to 0.1.39
d3658f9
to
6275a29
Compare
Thanks! Updated to 0.1.39. |
@bors r+ rollup=never Compiler-builtins updates have historically caused problems, so don't rollup to help with bisecting. |
📌 Commit 6275a29 has been approved by |
☀️ Test successful - checks-actions |
This version contains the fixes of rust-lang/compiler-builtins#390 and rust-lang/compiler-builtins#391.
Also, rename features following rust-lang/compiler-builtins#386.