rustdoc: Avoid panic when parsing codeblocks for playground links #67818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks! @bors: r+ |
|
📌 Commit d0e0404b055fd2dce70ab71a2a883559f14e98f0 has been approved by |
bors
added
the
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #67853) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
`make_test` is also called when parsing codeblocks for the playground links so it should handle unwinds from the parser internally.
ollie27
force-pushed
the
rustdoc_playground_syntax_error
branch
from
d0e0404 to
efb876f
Compare
|
@bors r=GuillaumeGomez |
|
📌 Commit efb876f has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 5, 2020
…rror, r=GuillaumeGomez rustdoc: Avoid panic when parsing codeblocks for playground links `make_test` is also called when parsing codeblocks for the playground links so it should handle unwinds from the parser internally. Fixes rust-lang#63016 r? @GuillaumeGomez
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 5, 2020
…rror, r=GuillaumeGomez rustdoc: Avoid panic when parsing codeblocks for playground links `make_test` is also called when parsing codeblocks for the playground links so it should handle unwinds from the parser internally. Fixes rust-lang#63016 r? @GuillaumeGomez
bors
added a commit
that referenced
this pull request
Jan 5, 2020
Rollup of 5 pull requests Successful merges: - #67818 (rustdoc: Avoid panic when parsing codeblocks for playground links) - #67845 (Also remove const-hack for abs) - #67879 (Remove negative number check from float sqrt) - #67881 (Add backticks to various diagnostics) - #67882 (remove bespoke flock bindings) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_testis also called when parsing codeblocks for the playground links so it should handle unwinds from the parser internally.Fixes #63016
r? @GuillaumeGomez